Félix-Antoine Fortin

Results 30 comments of Félix-Antoine Fortin

Hi, There is no user interface in jupyter-lmod currently to do this.. To remove the collections, you will have to use the lmod cli. I will add this to the...

The following note has been left in the text: > (TODO: Where is this API TOKen set?) https://github.com/jupyterhub/jupyterhub/blob/main/docs/source/reference/services.md?plain=1#L247 It should probably be removed.

> @cmd-ntrf Can I add a workflow to test these tests in CI? I did not add it now as I am not sure if you are using shared runners...

Interesting, I have followed tmod recent development since we switched to Lmod years ago. Just to be certain, by tmod you mean this repo: https://github.com/cea-hpc/modules ? If both lmod and...

Amazing! - To keep things simple, do you think we can start with tmod >= 5.0? This would avoid implementing `set_env`. - The functions `modify_load_gen_py_script` and `modify_unload_gen_py_script` implements a logic...

> So, I do not know if there is actually a "need" to provide custom logic for load/unload commands. Let's keep this as an idea for now then. > I...

> In that case, what do you think about reworking the code base to use a more generic name `module` instead of `lmod`? The idea is just to change the...

We'll wait for the release of JupyterLab 4.0 before moving forward with this idea. The amount of code required to build the interface with foldable section like the one used...

> @cmd-ntrf Maybe it is a good idea to add tests in a separate PR? Just to have a cleaner discussion? Yes.

> * Changed extension named to `@jupyterlab/jupyterlab-lmod` to match standard convention. If you prefer to have your namespace `@cmd-ntrf`, let me know, I will change it back. I think the...