Deprecated Resource: `cloudflare_firewall_rule` and `cloudflare_filter`

[jason-riddle]

trafficstars

Describe the Bug

The cloudposse/zone/cloudflare module makes use of resources cloudflare_firewall_rule and cloudflare_filter. Because of this, there are these deprecation messages.

`cloudflare_firewall_rule` resource is in a deprecation phase that will
│ last for one year (May 1st, 2024). During this time period, this
│ resource is still fully supported but you are strongly advised
│ to move to the `cloudflare_ruleset` resource. For more information, see
│ https://developers.cloudflare.com/waf/reference/migration-guides/firewall-rules-to-custom-rules/#relevant-changes-for-terraform-users.

and

`cloudflare_filter` resource is in a deprecation phase that will
│ last for one year (May 1st, 2024). During this time period, this
│ resource is still fully supported but you are strongly advised
│ to move to the `cloudflare_ruleset` resource. For more information, see
│ https://developers.cloudflare.com/waf/reference/migration-guides/firewall-rules-to-custom-rules/#relevant-changes-for-terraform-users.

Expected Behavior

Should be able to use the module without any deprecation messages.

Steps to Reproduce

Create main.tf and add the following

module "cloudflare_zone" {
  source  = "cloudposse/zone/cloudflare"
  version = "0.5.0"
  enabled = true

  account_id   = "<your_account_id>"
  zone         = "<your_zone>"
  zone_enabled = false

  records = [
    # Google Site Verification
    {
      name    = "example.com"
      value   = "google-site-verification=123"
      type    = "TXT"
      ttl     = 1
      proxied = false
    }
  ]
}

Running apply will produce the deprecation messages.

Screenshots

No response

Environment

• OS: OSX
• OS Version: 12.6.3
• Module Version: 0.5.0
• Terraform Version: 1.4.5

Additional Context

• Firewall rules are becoming WAF custom rules
  • Relevant changes for Terraform users

[bcdady]

I just ran into this same error. Bump.

[ramki-certn]

I just ran into this same error. Bump.

[purduemike]

Any fix available for this? Ran into this today.

[osterman]

Any pull requests welcome. We don't have any active customer engagements that could sponsor this work. Tag us in #pr-reviews on SweetOps to prioritize review.