terraform-aws-rds-cluster icon indicating copy to clipboard operation
terraform-aws-rds-cluster copied to clipboard

Fix: InvalidParameterValue: CreateDBInstance error when creating non-aurora multi a-z rds cluster and aws provider update

Open matharoo opened this issue 3 years ago • 2 comments

what

  • For a multi a-z rds cluster skip creating aws_rds_cluster_instance resource when engine type is NOT aurora, aurora-mysql, aurora-postgresql
  • AWS provider has a bug that is causing the terraform apply to fail due to a missing rebooting state. I have a PR merged with terraform-aws-provider that fixes it and will be included in the next release 4.23.0.
    • https://github.com/hashicorp/terraform-provider-aws/pull/25718

why

  • Prevent terraform from crashing when creating a non-aurora multi a-z cluster.
  • aws provider update for fixing rebooting state when creating multi a-z cluster.

references

  • closes https://github.com/cloudposse/terraform-aws-rds-cluster/issues/148
  • https://github.com/hashicorp/terraform-provider-aws/pull/25718

matharoo avatar Jul 11 '22 22:07 matharoo

/test all

Gowiem avatar Jul 23 '22 14:07 Gowiem

I think this change should have its own test. Maybe it can reuse on of the root modules in examples/ and use a custom tfvars to verify that this would work as expected

nitrocode avatar Aug 11 '22 03:08 nitrocode

I think this change should have its own test. Maybe it can reuse on of the root modules in examples/ and use a custom tfvars to verify that this would work as expected

done. the test can be found at examples/postgres

matharoo avatar Aug 15 '22 22:08 matharoo

/test all

nitrocode avatar Aug 16 '22 03:08 nitrocode