aws provider ver 4 upgrade fixed elb logs bucket

[benmotyka]

what

Fixed creating environment for version 4.0.0 aws provider

why

With the recent aws provider version 4 upgrade, significant changes to s3 bucket resource were introduced.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade#policy-argument https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade#acl-argument https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade#server_side_encryption_configuration-argument https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade#versioning-argument https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-4-upgrade#logging-argument

[nitrocode]

Hi @benmotyka. Thank you for the contribution. We currently have an s3 bucket module that has been updated to our latest standards, just like our security group module.

We're hoping that we can remove all s3 raw resources from our modules and instead consume our resource specific modules to keep consistency.

• https://github.com/cloudposse/terraform-aws-s3-bucket
• https://github.com/cloudposse/terraform-aws-security-group (another example, no need to update this pr to use it)

In other modules, we've been migrating to the updated s3 module and its appropriate inputs, deprecating old inputs, updating tests, updating examples/, updating the readme, creating a migration guide in docs/, running through the migration guide.

It's a lot to sign up for but if you or someone is willing to do it then please update the PR and someone from our team can help guide and review.

cc: @joe-niland