terraform-aws-elastic-beanstalk-environment icon indicating copy to clipboard operation
terraform-aws-elastic-beanstalk-environment copied to clipboard

Add variable to disable S3 eb-loadbalancer-logs

Open tranquyetdev opened this issue 4 years ago • 4 comments

what

  • Add a variable enable_elb_logs to control whether or not to enable ELB logs, default value is true
  • If enable_elb_logs=false then the resource aws_s3_bucket.elb_logs won't be created.

why

  • In some business cases, we don't want to store elb_logs for cost-saving and don't want to maintain it to save our effort for security compliance.
  • This pull request will add a bool variable enable_elb_logs, default = true

references

  • #152

tranquyetdev avatar Apr 17 '21 13:04 tranquyetdev

This pull request is now in conflict. Could you fix it @tranquyetdev? 🙏

mergify[bot] avatar Jul 26 '21 08:07 mergify[bot]

Hello @tranquyetdev

Are you still available to push this feature to master ? I would be glad to help you if you fix recent suggestions and conflicts.

florian0410 avatar Aug 26 '21 13:08 florian0410

@tranquyetdev please resolve the conflicts

aknysh avatar Dec 31 '21 16:12 aknysh

@tranquyetdev please resolve the conflicts

aknysh avatar Jan 18 '22 15:01 aknysh