terraform-aws-ecs-alb-service-task icon indicating copy to clipboard operation
terraform-aws-ecs-alb-service-task copied to clipboard
verified publisher icon cloudposse

fix: create task definition before destroying the existing one

Open syphernl opened this issue 4 years ago • 3 comments

what

  • Added create_before_destroy to the task definition

why

  • Currently, when applying the state fails you will be left out with a task definition

syphernl avatar Sep 09 '21 11:09 syphernl

/test all

nitrocode avatar Sep 09 '21 11:09 nitrocode

hi @syphernl. Thanks for the contribution. We're still waiting for the new sg module 0.4.0 to be used with this repo before this repos code is unfrozen. Please wait for us to complete that before we merge this pr.

nitrocode avatar Sep 09 '21 11:09 nitrocode

@nitrocode @aknysh create_before_destroy is a breaking change. It can be folded into the Security Group 0.4.0 upgrade, but please assess the cost/benefit of the change before introducing it, and provide a migration strategy suitable for a live production environment.

Nuru avatar Dec 27 '21 20:12 Nuru

@nitrocode @Nuru Any updates on this one?

syphernl avatar Feb 02 '23 14:02 syphernl

/terratest

hans-d avatar Mar 02 '24 17:03 hans-d