terraform-aws-ec2-bastion-server icon indicating copy to clipboard operation
terraform-aws-ec2-bastion-server copied to clipboard

In main.tf : resource aws_eip replace deprecated vpc argument by domain

Open RobinMayo opened this issue 2 years ago • 4 comments

what

Remove deprecated argument in resource aws_eip and replace it with the new argument recommended by Hashicorp AWS provider.

why

To remove terraform warning when plan or apply stack and to be up to date.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eip

RobinMayo avatar Jun 01 '23 15:06 RobinMayo

Note that this module has other AWS provider V5 issues: https://github.com/cloudposse/actions/actions/runs/5123264908

I will not be able to merge until I fix those.

max-lobur avatar Jun 01 '23 15:06 max-lobur

Thanks for your response. To be honest, I wanted to see if this module was still maintained. I am glad to see your reactivity ! I will look for other aws 5.0 issues or deprecation.

Regards

RobinMayo avatar Jun 02 '23 08:06 RobinMayo

Hello! Any news?

bsramin avatar Aug 14 '23 14:08 bsramin

if the project is abandoned, please write it, or if you are looking for some new maintainer...

bsramin avatar Feb 06 '24 16:02 bsramin

/terratest

hans-d avatar Mar 08 '24 11:03 hans-d

Thanks @RobinMayo for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] avatar Mar 09 '24 04:03 mergify[bot]

Any update here?

loganbest avatar May 09 '24 18:05 loganbest

💥 This pull request now has conflicts. Could you fix it @RobinMayo? 🙏

mergify[bot] avatar May 10 '24 07:05 mergify[bot]

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.

mergify[bot] avatar May 10 '24 07:05 mergify[bot]