terraform-aws-ec2-bastion-server
terraform-aws-ec2-bastion-server copied to clipboard
In main.tf : resource aws_eip replace deprecated vpc argument by domain
what
Remove deprecated argument in resource aws_eip and replace it with the new argument recommended by Hashicorp AWS provider.
why
To remove terraform warning when plan or apply stack and to be up to date.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eip
Note that this module has other AWS provider V5 issues: https://github.com/cloudposse/actions/actions/runs/5123264908
I will not be able to merge until I fix those.
Thanks for your response. To be honest, I wanted to see if this module was still maintained. I am glad to see your reactivity ! I will look for other aws 5.0 issues or deprecation.
Regards
Hello! Any news?
if the project is abandoned, please write it, or if you are looking for some new maintainer...
/terratest
Thanks @RobinMayo for creating this pull request!
A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.
While you wait, make sure to review our contributor guidelines.
[!TIP]
Need help or want to ask for a PR review to be expedited?
Join us on Slack in the
#pr-reviewschannel.
Any update here?
💥 This pull request now has conflicts. Could you fix it @RobinMayo? 🙏
This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.