terraform-aws-api-gateway icon indicating copy to clipboard operation
terraform-aws-api-gateway copied to clipboard

feat: extend retention period for API Gateway logs

Open HectorQuiroz opened this issue 1 year ago • 4 comments

what

This feature allows users to customize the retention period of the logs in CloudWatch.

why

This is useful for users who need to keep logs for longer periods of time for auditing or compliance purposes.

references

https://github.com/cloudposse/terraform-aws-api-gateway/issues/48

HectorQuiroz avatar Aug 27 '24 19:08 HectorQuiroz

And also add a type? I believe this is an int and not a string

RoseSecurity avatar Sep 12 '24 22:09 RoseSecurity

And also add a type? I believe this is an int and not a string

Hello @RoseSecurity ,

The module documentation says that this variable is a string

image

Repository: https://github.com/cloudposse/terraform-aws-cloudwatch-logs Variable: line 12 -15 https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/main/variables.tf

HectorQuiroz avatar Sep 23 '24 21:09 HectorQuiroz

Is there any way you could run the following to update the docs?

make init
make readme

hey @RoseSecurity ,

I ran make init & make readme to update the documentation. 🚀

HectorQuiroz avatar Sep 23 '24 21:09 HectorQuiroz

LGTM thanks @HectorQuiroz

Thanks @jamengual, I've set the type to be a string as required by tf lint. Can you please approve it again? 💯

HectorQuiroz avatar Sep 23 '24 21:09 HectorQuiroz

And also add a type? I believe this is an int and not a string

Hello @RoseSecurity ,

The module documentation says that this variable is a string

image Repository: https://github.com/cloudposse/terraform-aws-cloudwatch-logs Variable: line 12 -15 https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/main/variables.tf

HectorQuiroz avatar Oct 30 '24 15:10 HectorQuiroz