terraform-aws-amplify-app icon indicating copy to clipboard operation
terraform-aws-amplify-app copied to clipboard

add ability to write secrets for amplify app

Open kevcube opened this issue 1 year ago • 8 comments

what

Amplify can access secrets during build and runtime This PR allows the

why

It may be useful depending on a user's secrets management pattern to write secrets here when creating the amplify app.

references

https://docs.aws.amazon.com/amplify/latest/userguide/environment-variables.html#environment-secrets fixes #31

kevcube avatar Apr 30 '24 18:04 kevcube

/terratest

goruha avatar Jun 20 '24 22:06 goruha

💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏

mergify[bot] avatar Jul 15 '24 16:07 mergify[bot]

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.

mergify[bot] avatar Jul 22 '24 16:07 mergify[bot]

💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏

mergify[bot] avatar Jul 22 '24 16:07 mergify[bot]

/terratest

kevcube avatar Jul 22 '24 16:07 kevcube

@kevcube, why can't a secret be written externally based on the module's outputs after the Amplify app is created?

It can be written externally, if someone wants to use remote-state or something to grab the amplify ID that's an option, but because amplify has the ability to access secrets stored at these predefined paths I thought it made sense to package in this module because they can be considered a part of the amplify application stack

kevcube avatar Jul 22 '24 18:07 kevcube

@kevcube, why can't a secret be written externally based on the module's outputs after the Amplify app is created?

@goruha do you have a reason why it should not be included in this module?

kevcube avatar Jul 23 '24 18:07 kevcube

/terratest

goruha avatar Jul 25 '24 22:07 goruha

💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏

mergify[bot] avatar Oct 13 '24 15:10 mergify[bot]

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.

mergify[bot] avatar Oct 13 '24 15:10 mergify[bot]