build-harness icon indicating copy to clipboard operation
build-harness copied to clipboard

Use github/download-private-release when GITHUB_TOKEN exists

Open goruha opened this issue 7 years ago • 1 comments
trafficstars

What

  • Refactor github/download-public-release to use github/download-private-release if GITHUB_TOKEN exists.

Why

  • If GITHUB_TOKEN exists we use an authenticated call that has limits 5000 per day per IP else we call anonymous call that has limits to 60 per day per IP.

Workaround

  • Make exits non-zero error if anonymous request limit hit.

goruha avatar Apr 02 '18 17:04 goruha

I think we should move to using fetch: https://github.com/gruntwork-io/fetch

osterman avatar Apr 19 '18 20:04 osterman