atmos icon indicating copy to clipboard operation
atmos copied to clipboard

refactor tests to avoid atmos binary

Open osterman opened this issue 5 months ago • 1 comments
trafficstars

what

  • run test cases via cmd.Execute() instead of compiled binary
  • update terraform CLI tests to use helper
  • fix golangci configuration for lint
  • document in-process test execution
  • clarify lint instructions in AGENTS.md
  • disable timestamp in logs for in-process test helper

why

  • executing the compiled binary in tests caused flakiness and reliance on external artifacts
  • running commands in-process provides faster, more reliable testing
  • lint required --new=false since the container isn't a full git repo
  • log timestamps broke golden snapshots

references

  • n/a

https://chatgpt.com/codex/tasks/task_b_68597d71f1c48332971e1760f706d4b8

osterman avatar Jun 24 '25 14:06 osterman

[!WARNING]

This PR exceeds the recommended limit of 1,000 lines.

Large PRs are difficult to review and may be rejected due to their size.

Please verify that this PR does not address multiple issues. Consider refactoring it into smaller, more focused PRs to facilitate a smoother review process.

mergify[bot] avatar Aug 26 '25 13:08 mergify[bot]

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

mergify[bot] avatar Aug 26 '25 13:08 mergify[bot]

💥 This pull request now has conflicts. Could you fix it @osterman? 🙏

mergify[bot] avatar Aug 27 '25 20:08 mergify[bot]

superseded by #1534

osterman avatar Sep 27 '25 02:09 osterman