kube-router icon indicating copy to clipboard operation
kube-router copied to clipboard

feat: add rhel9 spec file along with its own build script

Open damex opened this issue 1 year ago • 3 comments

here we add:

  • rpm spec file (rhel9 and derivatives)
  • build/lint script to actually build rpm package
  • docs

damex avatar Aug 26 '24 19:08 damex

If you want rpms, can we use goreleaser to create them? https://goreleaser.com/customization/nfpm/

mrueg avatar Aug 27 '24 18:08 mrueg

If you want rpms, can we use goreleaser to create them? https://goreleaser.com/customization/nfpm/

it is using fpm. fpm is much worse solution for building rpms compared to building spec files. spec file is a self contained thing to build software with that will be packaged to an rpm while fpm just takes a config or binary or whatever and packs them in to rpm. quite different isn't it?

damex avatar Aug 28 '24 06:08 damex

It's using https://github.com/goreleaser/nfpm and not fpm :)

The advantage is that it'll be embedded in the release process and we don't need to have another process that might fail. At least @aauren and I won't be able to support rpm builds.

mrueg avatar Aug 28 '24 07:08 mrueg

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 28 '24 02:10 github-actions[bot]

This PR was closed because it has been stale for 10 days with no activity.

github-actions[bot] avatar Nov 08 '24 02:11 github-actions[bot]