cloudinary-laravel icon indicating copy to clipboard operation
cloudinary-laravel copied to clipboard

Error on the return value of CloudinaryLabs\CloudinaryLaravel\CloudinaryAdapter::readStream()

Open AndikanGabriel opened this issue 1 year ago • 2 comments

The readStream method of a storage driver is likely expected to return a resource type, but in this package, it is set to bool.

https://github.com/cloudinary-community/cloudinary-laravel/blob/434bb1fff2ef54e68bf5e4e05dbf8cf6bb3cf37b/src/CloudinaryAdapter.php#L291

Upon inspecting its return type, it appears that a boolean value is not returned.

https://github.com/cloudinary-community/cloudinary-laravel/blob/434bb1fff2ef54e68bf5e4e05dbf8cf6bb3cf37b/src/CloudinaryAdapter.php#L291-L296

I’m not sure if a fix is in the pipeline.

AndikanGabriel avatar Sep 06 '24 16:09 AndikanGabriel