php-buildpack
php-buildpack copied to clipboard
Updates a length check that was always true before
In file: init.py, the comparison of Collection length creates a logical short circuit.
I suggested that the Collection length comparison should be done without creating a logical short circuit. The suggested change needs to be reviewed by a domain expert.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: munahaf / name: Munawar (b01da0c908b8ac1ed5f3feb95f7e8a90910d8c23)
Hey @munahaf, could you provide a bit more information about the use case you're running into which is causing this to be an issue?
This did not come from a specific use case. We ran a code analysis tool that reported this. Hence submitted the PR to fix this case.