nodejs-buildpack icon indicating copy to clipboard operation
nodejs-buildpack copied to clipboard

Add option --retry-all-errors when downloading go version

Open ivanovac opened this issue 2 years ago • 2 comments

Add option --retry-all-errors when downloading go version

  • A short explanation of the proposed change: Adding option --retry-all-errors to the curl command used to download the go binary

  • An explanation of the use cases your change solves Using just the --retry option of curl doesn't make the call stable enough as it would fail to retry in cases of 'Connection reset by peer' when there's an TCP/IP issue while trying to connect to the host, for example. Adding --retry-all-errors option to the --retry [x], would cause retry of the call, no matter what the responce error is. In this concrete case, as the called url is well known (https://buildpacks.cloudfoundry.org/dependencies/go), adding --retry-all-errors would make the call even more resilient.

  • [x] I have viewed signed and have submitted the Contributor License Agreement

  • [x] I have made this pull request to the develop branch

  • [ ] I have added an integration test

ivanovac avatar Nov 29 '23 13:11 ivanovac

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: ivanovac / name: Tsvetelina Marinova (a99a709b8999b2590119591f6cf04c7e37d5913a, 4ea757b2f4751d073a203254288c7e041ddeb482, 1d300f84d4920cb5c64faeb39df1a7e3e0143653)

The change is not compatible with cflinuxfs3 as the curl version there is < 1.77 . So we should merge the change once the node-buildpack stops supporting the old stack.

radoslav-tomov avatar Nov 30 '23 06:11 radoslav-tomov