pat icon indicating copy to clipboard operation
pat copied to clipboard

Fix issue: Setting a custom file name for output does nothing #115

Open krishnamk00 opened this issue 10 years ago • 2 comments

logging:file parameter passed was not taking as output file instead always PAT takes the default output file format always. This fix will:

  • Take the argument passed a output file and place it in the correct output dir.
  • If file is passed as dir/file format it checks the format and process the file, else it used to create panic.

krishnamk00 avatar Apr 27 '15 09:04 krishnamk00

Hey krishna-mk!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

cfdreddbot avatar Apr 27 '15 09:04 cfdreddbot

Hey there,

This looks like a good idea, but it's currently broken - you missed an ending } in logs/config.go, so it won't even compile. You also didn't write any tests describing the new feature - think you could add some?

jberkhahn avatar May 02 '15 01:05 jberkhahn