docker-boshrelease icon indicating copy to clipboard operation
docker-boshrelease copied to clipboard

Add configurable login parameters

Open Nibooor opened this issue 5 years ago • 3 comments

Hi,

similar to the issue #77 and PR #104 I think that not having the option to use images from a private (i.e. login-protected) registry is quite a limitation. I tried a different, simpler approach than #104, that consists in maintaining the login information at the container job and adding a docker login and docker pull to the ctl before starting the container.

What do the maintainers think about this approach? I gathered that there are more people trying to do this.

Change:

Add configurable login parameters to pull images from custom (private) docker registries where authentication is needed.

  • Add properties login.name, login.password, login.server to container job and create environment variable for login parameters from these properties
  • Add docker login and docker pull commands to job ctl that is executed if the login properties are set

Nibooor avatar Dec 01 '20 08:12 Nibooor

CLA Signed

The committers are authorized under a signed CLA.

  • :white_check_mark: Robin (0fc1d60a4bdb907862e9990564c2dcf369d733f9)

Stale pull request message

github-actions[bot] avatar Aug 05 '21 09:08 github-actions[bot]

@neil-hickey Any chance somebody could do a code review for this change? I see you recently merged some PRs, maybe you can help to identify somebody to look into this.

thoHeinze avatar Aug 07 '21 20:08 thoHeinze