wrangler-legacy icon indicating copy to clipboard operation
wrangler-legacy copied to clipboard

Consider using cargo-generate v0.6.0+

Open jashandeep-sohi opened this issue 4 years ago • 5 comments
trafficstars

💡 cargo-generate v0.6.0+

Describe the feature

Currently wrangler generate ... calls out to cargo-generate v0.5.0 to template out any files. From v0.6.0+ cargo-generate supports template defined placeholders (aka custom variables) that allows template authors to better customize templates based on user prompts.

Would it be possible to bump the dependency on cargo-generate to at least v0.6.0 (but preferably to the latest release)?

Describe the alternatives

My hack was to copy over a build of cargo-generate (v0.7.0) to $HOME/.cache/.wrangler/cargo-generate-0.5.0/cargo-generate. Not really a solution, but a good way to test out things without making any code changes.

jashandeep-sohi avatar Jul 19 '21 03:07 jashandeep-sohi

@jashandeep-sohi - thanks for the suggestion! I'll try it out and see if there is any objection to doing this.

nilslice avatar Jul 19 '21 15:07 nilslice

I think our blocker right now is that cargo-generate does not distribute already-built binaries through GitHub releases (like it use to)

Electroid avatar Jul 23 '21 15:07 Electroid

I think our blocker right now is that cargo-generate does not distribute already-built binaries through GitHub releases (like it use to)

Hopefully since v0.7.2 it should :wink: https://github.com/cargo-generate/cargo-generate/releases/tag/v0.7.2

jashandeep-sohi avatar Jul 23 '21 16:07 jashandeep-sohi

Thanks for adding that back @jashandeep-sohi! I'll update our tracking ticket to get this tested. Will update here with progress asap.

nilslice avatar Jul 23 '21 16:07 nilslice

This issue has been automatically marked as stale because it has not had recent activity in the last 180 days. It will be closed if no further activity occurs in the next week. Please feel free to comment if you'd like it to remain open, and thank you for your contributions.

stale[bot] avatar Mar 02 '22 09:03 stale[bot]

Thanks for reporting this issue! Wrangler v1 is now deprecated and support is only being provided for critical updates or security concerns. As such, we are closing this issue.

New versions of Wrangler are maintained in the workers-sdk repo. If you are running into a similar issue with wrangler v2, please report it in the workers-sdk repo. For more info about wrangler v1 deprecation, please check out our blog post.

admah avatar Feb 27 '23 16:02 admah