workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

allow printing hotkeys conditionally

Open emily-shen opened this issue 5 months ago • 3 comments

This prints the hotkeys after the dev env has been set up, so that we can access the config and register hotkeys conditionally based on that.

Looks like this:

Screenshot 2025-06-20 at 14 08 02


  • Tests
    • [ ] TODO (before merge)
    • [x] Tests included
    • [ ] Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [x] Required
    • [ ] Not required because:
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Documentation not necessary because: no functional change
  • Wrangler V3 Backport
    • [ ] TODO (before merge)
    • [ ] Wrangler PR:
    • [x] Not necessary because: hotkey printing has changed since v3

emily-shen avatar Jun 20 '25 13:06 emily-shen

🦋 Changeset detected

Latest commit: 3dd60f4c393b5b6e75089060eef715d37641ff05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 20 '25 13:06 changeset-bot[bot]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/print-hotkeys might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9695
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

github-actions[bot] avatar Jun 20 '25 13:06 github-actions[bot]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9695
@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9695
miniflare

npm i https://pkg.pr.new/miniflare@9695
@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9695
@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9695
@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9695
@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9695
@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9695
wrangler

npm i https://pkg.pr.new/wrangler@9695

commit: 3dd60f4

pkg-pr-new[bot] avatar Jun 20 '25 13:06 pkg-pr-new[bot]