workers-sdk
workers-sdk copied to clipboard
WC-2965 Prevent selecting in-progress deployments when tailing
If not provided with a deployment to tail, Wrangler will try to pull the list of deployments and select the most recently created one. However, we do not check whether this deployment has finished. This is causing intermittent errors for users.
Fixes #[insert GH or internal issue link(s)].
Describe your change...
- Tests
- [ ] TODO (before merge)
- [x] Tests included
- [ ] Tests not necessary because:
- Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- [ ] I don't know
- [x] Required
- [ ] Not required because:
- Public documentation
- [ ] TODO (before merge)
- [ ] Cloudflare docs PR(s):
- [x] Documentation not necessary because: n/a
- Wrangler V3 Backport
- [ ] TODO (before merge)
- [ ] Wrangler PR:
- [x] Not necessary because: this is the backport!
🦋 Changeset detected
Latest commit: 2b3bdaa42411f360220004608085f4ff03702553
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| wrangler | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@WillTaylorDev as discussed, please include @mlafeldt as co-author :)
@WillTaylorDev this PR looks to be superseded by https://github.com/cloudflare/workers-sdk/pull/9684? if so, can we close this one?
@WillTaylorDev this PR looks to be superseded by #9684? if so, can we close this one?
i think this is the v3 backport - i'll update the title to reflect