workers-sdk
workers-sdk copied to clipboard
WC-2965 Prevent selecting in-progress deployments when tailing
If not provided with a deployment to tail, Wrangler will try to pull the list of deployments and select the most recently created one. However, we do not check whether this deployment has finished. This is causing intermittent errors for users.
- Tests
- [ ] TODO (before merge)
- [x] Tests included
- [ ] Tests not necessary because:
- Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- [ ] I don't know
- [x] Required
- [ ] Not required because:
- Public documentation
- [ ] TODO (before merge)
- [ ] Cloudflare docs PR(s):
- [x] Documentation not necessary because: n/a
- Wrangler V3 Backport
- [ ] TODO (before merge)
- [x] Wrangler PR: https://github.com/cloudflare/workers-sdk/pull/9685
- [ ] Not necessary because:
🦋 Changeset detected
Latest commit: dfa97f733d2926fd9f8d213f63b904696e522164
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| wrangler | Patch |
| @cloudflare/vitest-pool-workers | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
create-cloudflare
npm i https://pkg.pr.new/create-cloudflare@9684
@cloudflare/kv-asset-handler
npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9684
miniflare
npm i https://pkg.pr.new/miniflare@9684
@cloudflare/pages-shared
npm i https://pkg.pr.new/@cloudflare/pages-shared@9684
@cloudflare/unenv-preset
npm i https://pkg.pr.new/@cloudflare/unenv-preset@9684
@cloudflare/vite-plugin
npm i https://pkg.pr.new/@cloudflare/vite-plugin@9684
@cloudflare/vitest-pool-workers
npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9684
@cloudflare/workers-editor-shared
npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9684
wrangler
npm i https://pkg.pr.new/wrangler@9684
commit: dfa97f7
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!
Depending on your changes, running git rebase --onto v3-maintenance main willtaylor/wc-2965-bugfix-pages-tail might be a good starting point.
Notes:
- your PR branch should be named
v3-backport-9684 - add the
skip-v3-prlabel to the current PR to stop this workflow from failing