workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Update buildAndMaybePush to use more robust method to find local digests

Open IRCody opened this issue 5 months ago • 2 comments

Older versions of docker sometimes will report the digest as "" which would break with the previous implementation. This implementation should correctly grab the values.

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • [ ] TODO (before merge)
    • [x] Tests included
    • [ ] Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [ ] Required
    • [x] Not required because: Modifying existing behavior that is not e2e tested afaik
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Documentation not necessary because: Makes existing method more robust but doesn't change user ux
  • Wrangler V3 Backport
    • [ ] TODO (before merge)
    • [ ] Wrangler PR:
    • [x] Not necessary because: feature doesn't exist in v3

IRCody avatar Jun 17 '25 22:06 IRCody

🦋 Changeset detected

Latest commit: 0bf56245c6ea23e908797420727485cae18a74f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 17 '25 22:06 changeset-bot[bot]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9641
@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9641
miniflare

npm i https://pkg.pr.new/miniflare@9641
@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9641
@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9641
@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9641
@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9641
@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9641
wrangler

npm i https://pkg.pr.new/wrangler@9641

commit: 0bf5624

pkg-pr-new[bot] avatar Jun 17 '25 22:06 pkg-pr-new[bot]

left a few nit comments, but LGTM otherwise.

CarmenPopoviciu avatar Jun 24 '25 10:06 CarmenPopoviciu

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main cdr/docker-inspect might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9641
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

github-actions[bot] avatar Jun 24 '25 17:06 github-actions[bot]