workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

fix(create-cloudflare): update to Analog 1.9.0 w/latest template

Open brandonroberts opened this issue 1 year ago • 1 comments

Fixes #[insert GH or internal issue link(s)].

  • Updates Analog to use latest upon installation
  • Removes installation of @ngtools/webpack
  • Removes Analog e2e test from quarantine.

  • Tests
    • [ ] TODO (before merge)
    • [x] Tests included
    • [x] Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [ ] Required
    • [ ] Not required because:
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [ ] Documentation not necessary because:

brandonroberts avatar Oct 22 '24 01:10 brandonroberts

⚠️ No Changeset found

Latest commit: 892d8f4d84ad24c4cde0e393f18f3aa0a6373c5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 22 '24 01:10 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-wrangler-7048

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7048/npm-package-wrangler-7048

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-wrangler-7048 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-create-cloudflare-7048 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-cloudflare-kv-asset-handler-7048
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-miniflare-7048
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-cloudflare-pages-shared-7048
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-cloudflare-vitest-pool-workers-7048
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-cloudflare-workers-editor-shared-7048
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-cloudflare-workers-shared-7048
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11549399625/npm-package-cloudflare-workflows-shared-7048

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Oct 22 '24 09:10 github-actions[bot]

thank you so much @brandonroberts for creating this PR ♥️ 🙏 . It seems that the analog e2e tests are still failing with the same fetch error :(. I wonder if it's the same issue we're seeing on https://github.com/cloudflare/workers-sdk/pull/6975 🤔

CarmenPopoviciu avatar Oct 22 '24 15:10 CarmenPopoviciu

@CarmenPopoviciu no problem! I'm digging into and trying to run the E2E tests locally. I think its not resolving the current working directory when scaffolding the application in a temp directory, so its not building the application correctly.

brandonroberts avatar Oct 22 '24 16:10 brandonroberts

Closing for now as this PR has gone stale. We should recreate it from scratch when there is capacity to land it.

petebacondarwin avatar Oct 21 '25 09:10 petebacondarwin