fix: ask for confirmation before creating a new worker when uploading secrets

[emily-shen]

Fixes WC-2856 In interactive mode, if someone specifies a worker name that does not yet exist, ask for confirmation before actually creating that worker (e.g. in case it was a typo).

In non-interactive contexts (CI etc.), always create a worker to maintain existing behaviour.

• Tests
  • [ ] TODO (before merge)
  • [x] Tests included
  • [ ] Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • [ ] I don't know
  • [ ] Required
  • [x] Not required because: covered by unit tests
• Public documentation
  • [ ] TODO (before merge)
  • [ ] Cloudflare docs PR(s):
  • [x] Documentation not necessary because: trivial interaction change

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 59071924697ce6bc1c7b5181395b0bde3bc7a122

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-wrangler-7037

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7037/npm-package-wrangler-7037

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-wrangler-7037 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-create-cloudflare-7037 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-cloudflare-kv-asset-handler-7037

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-miniflare-7037

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-cloudflare-pages-shared-7037

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-cloudflare-vitest-pool-workers-7037

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-cloudflare-workers-editor-shared-7037

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11458188212/npm-package-cloudflare-workers-shared-7037

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20241011.0
workerd	1.20241018.1	1.20241018.1
workerd --version	1.20241018.1	2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[emily-shen]

cc @tanushree-sharma

[tanushree-sharma]

Quick PR! Thanks @emily-shen.

Possible to move the check for a Worker up to before the user is prompted for the secret? Doing the Worker check first is better in the case that a user specified the wrong Worker name and wants to abort.

[emily-shen]

That would be ideal DX, but we'd have to add an extra "get worker" request to every secret upload and i'm not sure that's worth it. Currently we just directly upload the secret to an endpoint that's something like /workerName/secrets so it's just one request most of the time.