workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Reduce KV bulk upload size

Open penalosa opened this issue 1 year ago • 2 comments

Fixes #7021

Reduce the KV bulk upload size from 5_000 to 1_000 to try and help reduce API timeout issues


  • Tests
    • [ ] TODO (before merge)
    • [ ] Tests included
    • [x] Tests not necessary because: behaviour covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [ ] Required
    • [x] Not required because: no e2e coverage of KV
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Documentation not necessary because: internal bugfix

penalosa avatar Oct 21 '24 12:10 penalosa

🦋 Changeset detected

Latest commit: 9b6213c729e6089c7416c114d0d86fa7cd21bba8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 21 '24 12:10 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-wrangler-7036

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7036/npm-package-wrangler-7036

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-wrangler-7036 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-create-cloudflare-7036 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-kv-asset-handler-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-miniflare-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-pages-shared-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-vitest-pool-workers-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-workers-editor-shared-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-workers-shared-7036

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241018.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Oct 21 '24 12:10 github-actions[bot]

Moving this to draft pending internal discussion about whether or not this change will help things

penalosa avatar Oct 22 '24 12:10 penalosa