workers-sdk
workers-sdk copied to clipboard
Refactor hyperdrive create and update commands to match each other's behavior and address bug with individual parameters on creation
What this PR solves / how to test
Fixes SQC-338
fix: make individual parameters work for `wrangler hyperdrive create` when not using HoA
`wrangler hyperdrive create` individual parameters were not setting the database name correctly when calling the api.
refactor: use same param parsing code for `wrangler hyperdrive create` and `wrangler hyperdrive update`
ensures that going forward, both commands support the same features and have the same names for config flags
feature: allow using a connection string when updating hyperdrive configs
both `hyperdrive create` and `hyperdrive update` now support updating configs with connection strings.
Author has addressed the following
- Tests
- [ ] TODO (before merge)
- [X] Tests included
- [ ] Tests not necessary because:
- E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- [X] I don't know
- [ ] Required
- [ ] Not required because:
- Changeset (Changeset guidelines)
- [ ] TODO (before merge)
- [X] Changeset included
- [ ] Changeset not necessary because:
- Public documentation
- [X] TODO (before merge)
- [ ] Cloudflare docs PR(s):
- [ ] Documentation not necessary because: no changes
🦋 Changeset detected
Latest commit: 0db8edf832136e43486b9d063c9431bf035959b8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| wrangler | Minor |
| @cloudflare/vitest-pool-workers | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
A wrangler prerelease is available for testing. You can install this latest build in your project with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-wrangler-7024
You can reference the automatically updated head of this PR with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7024/npm-package-wrangler-7024
Or you can use npx with this latest build directly:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-wrangler-7024 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-create-cloudflare-7024 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-cloudflare-kv-asset-handler-7024
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-miniflare-7024
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-cloudflare-pages-shared-7024
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-cloudflare-vitest-pool-workers-7024
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-cloudflare-workers-editor-shared-7024
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-cloudflare-workers-shared-7024
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11572515343/npm-package-cloudflare-workflows-shared-7024
Note that these links will no longer work once the GitHub Actions artifact expires.
[email protected] includes the following runtime dependencies:
| Package | Constraint | Resolved |
|---|---|---|
miniflare |
workspace:* | 3.20241022.0 |
workerd |
1.20241022.0 | 1.20241022.0 |
workerd --version |
1.20241022.0 | 2024-10-22 |
Please ensure constraints are pinned, and miniflare/workerd minor versions match.
Overall I love the refactor, much cleaner and should be way easier to maintain going forward. I just think the ClientType names and contents need a once-over to align with the config service a bit more.
Looks good to me from the Hyperdrive Team side of things.