workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

chore: update devtools patches (2nd attempt)

Open andyjessop opened this issue 1 year ago • 2 comments

What this PR solves / how to test

Fixes #000.

Updates the DevTools patches. Note that this does not include the switch to the performance tab (but does remove the profiling tab), which will be completed in a separate PR.

Acceptance criteria:

Console tab:

  • Logging plain text ✅
  • Logging numbers ✅
  • Maintaining connection across script reloads (i.e. the "Script modified; context reset." message) ✅
  • Logging (explorable) structured data ✅
  • Logging thrown errors ✅
  • Filter by log level ✅
  • Ability to clear logs ✅

Sources tab:

  • View worker source ✅
  • Source updates (after deployed and request sent to edgeworker) ✅
  • Throwing an error correctly underlines the line of code which threw ❌ (1)

Network tab:

  • Subrequests are shown ✅
  • Response headers are shown ✅
  • Response bodies are shown ✅

[1] Not underlining throwing code in sources tab

However, note that this doesn't work on the existing production workers playground, so I don't think it should hold up this PR.

Screenshot 2024-10-18 at 14 54 43

Author has addressed the following

  • Tests
    • [ ] TODO (before merge)
    • [ ] Tests included
    • [x] Tests not necessary because: not covered by tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [ ] Required
    • [x] Not required because: doesn't affect existing tests
  • Changeset (Changeset guidelines)
    • [ ] TODO (before merge)
    • [ ] Changeset included
    • [x] Changeset not necessary because: just a refactor to keep it up-to-date
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Documentation not necessary because: not user facing

andyjessop avatar Oct 17 '24 14:10 andyjessop

🦋 Changeset detected

Latest commit: 14f5ee4b1fb408d6bc6661179fd709b4bdd1067b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/wrangler-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 17 '24 14:10 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-wrangler-7008

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7008/npm-package-wrangler-7008

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-wrangler-7008 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-create-cloudflare-7008 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-cloudflare-kv-asset-handler-7008
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-miniflare-7008
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-cloudflare-pages-shared-7008
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-cloudflare-vitest-pool-workers-7008
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-cloudflare-workers-editor-shared-7008
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-cloudflare-workers-shared-7008
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11521329644/npm-package-cloudflare-workflows-shared-7008

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Oct 17 '24 14:10 github-actions[bot]