workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

fix(workers-shared): Fix handling of path names with special characters

Open CarmenPopoviciu opened this issue 1 year ago • 2 comments

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • [x] TODO (before merge)
    • [ ] Included
    • [ ] Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [x] Required / Maybe required
    • [ ] Not required because:
  • Changeset (Changeset guidelines)
    • [x] TODO (before merge)
    • [ ] Included
    • [ ] Not necessary because:
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Not necessary because:

CarmenPopoviciu avatar Aug 23 '24 11:08 CarmenPopoviciu

⚠️ No Changeset found

Latest commit: e73c0b9a1fe9e59ecbb9a06f8909c740215cbfae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 23 '24 11:08 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-wrangler-6568

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6568/npm-package-wrangler-6568

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-wrangler-6568 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-create-cloudflare-6568 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-cloudflare-kv-asset-handler-6568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-miniflare-6568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-cloudflare-pages-shared-6568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-cloudflare-vitest-pool-workers-6568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-cloudflare-workers-editor-shared-6568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10524647650/npm-package-cloudflare-workers-shared-6568

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Aug 23 '24 11:08 github-actions[bot]