workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Update Svelte display name to SvelteKit

Open penalosa opened this issue 1 year ago • 2 comments

What this PR solves / how to test

Per https://github.com/cloudflare/workers-sdk/issues/3263#issuecomment-1888034131, this is what the Svelte team recommends. The Svelte framework template runs create-svelte which scaffolds a SvelteKit project, so this should make it clearer to users what type of project they're actually going to get.

Fixes #3263

Author has addressed the following

  • Tests
    • [ ] TODO (before merge)
    • [ ] Included
    • [x] Not necessary because: this doesn;t have any tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [ ] Required / Maybe required
    • [x] Not required because: e2e doesn't apply to c3
  • Changeset (Changeset guidelines)
    • [ ] TODO (before merge)
    • [x] Included
    • [ ] Not necessary because:
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Not necessary because: The Svelte guide skips this step with a CLI arg: https://developers.cloudflare.com/pages/framework-guides/deploy-a-svelte-site/

penalosa avatar Aug 23 '24 09:08 penalosa

🦋 Changeset detected

Latest commit: c71a539ec2d7259d9dba18ac0070e74737c00ee1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 23 '24 09:08 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-wrangler-6565

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6565/npm-package-wrangler-6565

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-wrangler-6565 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-create-cloudflare-6565 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-kv-asset-handler-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-miniflare-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-pages-shared-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-vitest-pool-workers-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-workers-editor-shared-6565
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10523495879/npm-package-cloudflare-workers-shared-6565

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Aug 23 '24 09:08 github-actions[bot]

Closing in favour of https://github.com/cloudflare/workers-sdk/pull/7109

penalosa avatar Nov 05 '24 18:11 penalosa