workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

feat(quick-edit): add "search.exclude" support to quick editor

Open edmundhung opened this issue 1 year ago • 2 comments

What this PR solves / how to test

Fixes DEVX-1384

This PR adds wrangler.toml and package.json to the files.exclude setting to reduce user confusions. It also makes these files not searchable anymore by adding search.exclude support, which inherits all glob patterns from the files.exclude setting.

Author has addressed the following

  • Tests
    • [ ] TODO (before merge)
    • [ ] Included
    • [ ] Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [x] I don't know
    • [ ] Required / Maybe required
    • [ ] Not required because:
  • Changeset (Changeset guidelines)
    • [ ] TODO (before merge)
    • [x] Included
    • [ ] Not necessary because:
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Not necessary because: No feature change

edmundhung avatar Aug 21 '24 13:08 edmundhung

🦋 Changeset detected

Latest commit: 796b8f64b1609a8d9c86a797cb63a7d62924c510

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/quick-edit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 21 '24 13:08 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-wrangler-6546

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6546/npm-package-wrangler-6546

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-wrangler-6546 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-create-cloudflare-6546 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-kv-asset-handler-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-miniflare-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-pages-shared-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-vitest-pool-workers-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-workers-editor-shared-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-workers-shared-6546

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Aug 21 '24 13:08 github-actions[bot]