workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

🚀 Feature Request: Wrangler type generator `RateLimit` type

Open Pedr0Rocha opened this issue 1 year ago • 1 comments

Describe the solution

Hello,

Now that this PR adding the type definition for the beta RateLimit binding is merged, is it worth adding it in the wrangler type generator? I would like to use it, but it gets overwritten by any when I generate the types.

Since it's still an unsafe binding, I assume the checks would still have to me made here for now and later on removed to become its own env field binding. Is there anywhere else it needs to be added?

If this is okay to add, I can open a PR with the type + tests.

Pedr0Rocha avatar Aug 19 '24 20:08 Pedr0Rocha

@Pedr0Rocha we'd be happy to accept a PR that adds this!

penalosa avatar Aug 21 '24 12:08 penalosa