workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

fix(miniflare): Fix regression introduced in #5570

Open CarmenPopoviciu opened this issue 1 year ago • 3 comments

What this PR solves / how to test

PR #5570 introduced a regression in Miniflare, namely that declaring Queue Producers like

queueProducers: { "MY_QUEUE": "my-queue" }

no longer works. This PR restores balance in the Miniflare + Queues Universe 🪐

Possibly addresses #5908

Author has addressed the following

  • Tests
    • [ ] TODO (before merge)
    • [x] Included
    • [ ] Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [ ] Required / Maybe required
    • [x] Not required because:
  • Changeset (Changeset guidelines)
    • [ ] TODO (before merge)
    • [x] Included
    • [ ] Not necessary because:
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [x] Not necessary because: regression fix

CarmenPopoviciu avatar Aug 16 '24 18:08 CarmenPopoviciu

🦋 Changeset detected

Latest commit: 2b35b2e1e51db8f77a803eb8d458277320baa27b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 16 '24 18:08 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-wrangler-6514

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6514/npm-package-wrangler-6514

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-wrangler-6514 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-create-cloudflare-6514 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-cloudflare-kv-asset-handler-6514
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-miniflare-6514
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-cloudflare-pages-shared-6514
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-cloudflare-vitest-pool-workers-6514
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-cloudflare-workers-editor-shared-6514
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10919919442/npm-package-cloudflare-workers-shared-6514

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Aug 16 '24 18:08 github-actions[bot]

Interested whether the Queue team has a view on this?

I've reached out to the queues team and waiting for them to get back to us on this.

I seem to remember that they were making a breaking change with this on purpose?

Sure, but given it's a breaking change, shouldn't it then have landed in a major version update rather than minor. Or was this an experimental feature at the time? And shouldn't docs have then be updated as well? Right now they still describe the contract prior to these changes

CarmenPopoviciu avatar Aug 20 '24 10:08 CarmenPopoviciu