workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

fix: remove invalid queueProducers schema

Open TimoWilhelm opened this issue 1 year ago • 2 comments

What this PR solves / how to test

Fixes #5908.

The following commit changes the schema for queueProducers in miniflare but the zod schema still accepts the old Record<string, string> schema which will cause sending to the queue to fail with a non-descriptive error. https://github.com/cloudflare/workers-sdk/commit/66bdad08834b403100d1e4d6cd507978cc50eaba#diff-0a38fa706f017d0142050f5bcd28eaed913461608cec13a4fa1461af12ff2d65L537

Author has addressed the following

  • Tests
    • [ ] TODO (before merge)
    • [ ] Included
    • [ ] Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [ ] I don't know
    • [ ] Required / Maybe required
    • [ ] Not required because:
  • Changeset (Changeset guidelines)
    • [ ] TODO (before merge)
    • [ ] Included
    • [ ] Not necessary because:
  • Public documentation
    • [ ] TODO (before merge)
    • [ ] Cloudflare docs PR(s):
    • [ ] Not necessary because:

TimoWilhelm avatar Jun 22 '24 10:06 TimoWilhelm

⚠️ No Changeset found

Latest commit: da7c6f98b317fe3605e3adb869ce68df2cbb691d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 22 '24 10:06 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-wrangler-6128

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6128/npm-package-wrangler-6128

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-wrangler-6128 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-create-cloudflare-6128 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-cloudflare-kv-asset-handler-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-miniflare-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-cloudflare-pages-shared-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-cloudflare-vitest-pool-workers-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-cloudflare-workers-editor-shared-6128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10406802464/npm-package-cloudflare-workers-shared-6128

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Jun 23 '24 11:06 github-actions[bot]

hi @TimoWilhelm

can you please rebase this PR on latest main 🙏 ? Otherwise CI won't run

CarmenPopoviciu avatar Aug 15 '24 07:08 CarmenPopoviciu

hi @TimoWilhelm

can you please rebase this PR on latest main 🙏 ? Otherwise CI won't run

It's updated

TimoWilhelm avatar Aug 15 '24 16:08 TimoWilhelm

thank you! running CI...

CarmenPopoviciu avatar Aug 15 '24 16:08 CarmenPopoviciu

@TimoWilhelm thank you for this fix ♥️ . I will close this PR in favour of https://github.com/cloudflare/workers-sdk/pull/6514 since that handles the actual regression we introduced a while

CarmenPopoviciu avatar Aug 16 '24 18:08 CarmenPopoviciu