workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Validate duplicate bindings across all binding types

Open penalosa opened this issue 1 year ago • 4 comments

What this PR solves / how to test

Fixes #2893

Author has addressed the following

  • Tests
    • [ ] TODO (before merge)
    • [ ] Included
    • [x] Tests not necessary because: behaviour already tested, this PR just adds it to more bindings (and adds a type level to check to make sure this doesn't regress)
  • Changeset (Changeset guidelines)
    • [ ] TODO (before merge)
    • [x] Included
    • [ ] Not necessary because:
  • Public documentation

penalosa avatar May 01 '24 17:05 penalosa

🦋 Changeset detected

Latest commit: cc87ccd5e799ea2d27b8c37e5297bfceb5b17fef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 01 '24 17:05 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-wrangler-5737

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5737/npm-package-wrangler-5737

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-wrangler-5737 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-create-cloudflare-5737 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-kv-asset-handler-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-miniflare-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-pages-shared-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-vitest-pool-workers-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-workers-editor-shared-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11445420406/npm-package-cloudflare-workers-shared-5737

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar May 01 '24 17:05 github-actions[bot]

this LGTM. Left a small comment + don't forget about adding a changeset. Otherwise, good to go

CarmenPopoviciu avatar May 30 '24 10:05 CarmenPopoviciu

@penalosa do we still want to land this?

CarmenPopoviciu avatar Jul 22 '24 07:07 CarmenPopoviciu