workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

[do not merge] dispatch namespaces in dev

Open GregBrimble opened this issue 1 year ago • 3 comments

Still to do

  • [ ] Environments (from a very brief glance at the code, these look like they could be busted across all local dev bindings incl. service bindings/DOs?)
  • [ ] WebSockets (I assume supported in prod?)
  • [ ] RPC (definitely won't be supported here and the way I've hacked this in is objectively wrong for RPC support, so we need to test what happens in prod and very probably rip out a chunk of what I've done in this PR to fix properly)
  • [ ] Dispatching from Pages projects (not supported in prod, but we should probably follow up with that quickly anyway — there's some weirdness in this PR around validation because of it)
  • [ ] Does production support non-JSON-stringify-able (e.g. v8 serializable) parameters?
  • [ ] In prod, do script env var bindings take precedence over parameters in outbound scripts? Or vice versa? I guessed and made parameters take precedence here.
  • [ ] I've pulled up dispatch_namespaces to a non-inheritable config field. It was previously kinda both inheritable and non-inheritable, depending on where you looked in the code.
  • [ ] Need to fix the tests in CI incl. the Pages variant (but Workers one works locally 🎉)
  • [ ] Confirm happy with --dispatch (very confusing, but vaguely consistent)
  • [ ] What happens if I pass in parameters but don't allow-list them in the binding?
  • [ ] Does dispatch_namespace in wrangler.toml work for wrangler deploy too?

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

GregBrimble avatar Apr 15 '24 23:04 GregBrimble

⚠️ No Changeset found

Latest commit: d42ccb8d90fe9a1eb0635b183fcbd15eac0d13d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 15 '24 23:04 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8712540483/npm-package-wrangler-5622

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5622/npm-package-wrangler-5622

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8712540483/npm-package-wrangler-5622 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8712540483/npm-package-create-cloudflare-5622 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8712540483/npm-package-cloudflare-kv-asset-handler-5622
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8712540483/npm-package-miniflare-5622
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8712540483/npm-package-cloudflare-pages-shared-5622
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8712540483/npm-package-cloudflare-vitest-pool-workers-5622

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.1
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Apr 15 '24 23:04 github-actions[bot]

Hi, would it be possible to update this with the latest main, and publish an NPM release? I'm missing the module aliasing feature that got added later. Thanks.

dmaretskyi avatar Sep 02 '24 11:09 dmaretskyi

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-wrangler-5622
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-workers-bindings-extension-5622 -O ./cloudflare-workers-bindings-extension.0.0.0-v0e3ac3176.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v0e3ac3176.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-create-cloudflare-5622 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-kv-asset-handler-5622

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-miniflare-5622

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-pages-shared-5622

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-unenv-preset-5622

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-vite-plugin-5622

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-vitest-pool-workers-5622

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-workers-editor-shared-5622

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-workers-shared-5622

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14869277658/npm-package-cloudflare-workflows-shared-5622

Note that these links will no longer work once the GitHub Actions artifact expires.

github-actions[bot] avatar May 06 '25 20:05 github-actions[bot]

Closing this since it's no longer referenced in the docs page: https://developers.cloudflare.com/cloudflare-for-platforms/workers-for-platforms/get-started/developing-with-wrangler/ and is pretty stale

penalosa avatar Sep 10 '25 10:09 penalosa