workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Deploy non-npm packages via changesets

Open petebacondarwin opened this issue 1 year ago • 3 comments

What this PR solves / how to test:

This PR consolidates our production deployment of packages, Workers and Pages projects to all use the changesets tooling.

To do so, changesets has been configured to additionally "version" (i.e. to bump and manage the versions of) private packages. The Github action responsible for handling the changesets has been updated to then run pnpm deploy on any changed packages that are marked as private (and so have not been deployed via npm already).

Preview releases (both on npm and Pages) continue to work as before.

The following packages are now managed by changesets, and will only be released to production when there are appropriate changesets in the Version Packages PR:

  • edge-preview-authenticated-proxy
  • format-errors
  • playground-preview-worker
  • @cloudflare/prerelease-registry
  • @cloudflare/quick-edit
  • turbo-r2-archive
  • workers-playground
  • workers.new
  • @cloudflare/wrangler-devtools

(Previously, the turbo-r2-archive package was only deployable manually and @cloudflare/prerelease-registry was deployed on every push to main.)

Packages that are marked as private and do not have a deploy script will not be deployable by changesets, which is essential for internal packages like @cloudflare/cli.

Author has addressed the following:

  • Tests
    • [x] Included
    • [ ] Not necessary because:
  • Changeset (Changeset guidelines)
    • [ ] Included
    • [x] Not necessary because: internal tooling change
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [x] Not necessary because: no external user change, although a number of READMEs in the repo have been updated accordingly.

petebacondarwin avatar Mar 01 '24 09:03 petebacondarwin

⚠️ No Changeset found

Latest commit: a0703b9580d76d4a86b74e6c78d624970e730ff6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 01 '24 09:03 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155564805/npm-package-wrangler-5130

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5130/npm-package-wrangler-5130

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155564805/npm-package-wrangler-5130 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155564805/npm-package-create-cloudflare-5130 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155564805/npm-package-cloudflare-kv-asset-handler-5130
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155564805/npm-package-miniflare-5130
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155564805/npm-package-cloudflare-pages-shared-5130
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8155564805/npm-package-cloudflare-vitest-pool-workers-5130

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Mar 01 '24 09:03 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.33%. Comparing base (24b4c42) to head (a0703b9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5130      +/-   ##
==========================================
+ Coverage   70.31%   70.33%   +0.01%     
==========================================
  Files         298      298              
  Lines       15551    15551              
  Branches     4001     4001              
==========================================
+ Hits        10935    10938       +3     
+ Misses       4616     4613       -3     

see 5 files with indirect coverage changes

codecov[bot] avatar Mar 01 '24 09:03 codecov[bot]