workers-sdk
workers-sdk copied to clipboard
[C3] fix: make sure that all C3 projects include in their `.gitignore` the wrangler files
What this PR solves / how to test:
previously only the worker templates included in their .gitignore the wrangler files
(those being .dev.vars and .wrangler), make sure to instead include such files in
the .gitignore files of all the templates including the full stack ones
Author has addressed the following:
- Tests
- [x] Included
- [ ] Not necessary because:
- Changeset (Changeset guidelines)
- [x] Included
- [ ] Not necessary because:
- Associated docs
- [ ] Issue(s)/PR(s):
- [x] Not necessary because: quality of life improvement not needing documentation
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.
🦋 Changeset detected
Latest commit: 36c028ca2ec820fdf5c45b67fdf8941e0e5b3b17
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| create-cloudflare | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
A wrangler prerelease is available for testing. You can install this latest build in your project with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147445097/npm-package-wrangler-5129
You can reference the automatically updated head of this PR with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5129/npm-package-wrangler-5129
Or you can use npx with this latest build directly:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147445097/npm-package-wrangler-5129 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147445097/npm-package-create-cloudflare-5129 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147445097/npm-package-cloudflare-kv-asset-handler-5129
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147445097/npm-package-miniflare-5129
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147445097/npm-package-cloudflare-pages-shared-5129
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8147445097/npm-package-cloudflare-vitest-pool-workers-5129
Note that these links will no longer work once the GitHub Actions artifact expires.
[email protected] includes the following runtime dependencies:
| Package | Constraint | Resolved |
|---|---|---|
miniflare |
workspace:* | 3.20240223.0 |
workerd |
1.20240223.1 | 1.20240223.1 |
workerd --version |
1.20240223.1 | 2024-02-23 |
Please ensure constraints are pinned, and miniflare/workerd minor versions match.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.36%. Comparing base (
4194495) to head (36c028c). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5129 +/- ##
==========================================
+ Coverage 70.31% 70.36% +0.04%
==========================================
Files 298 298
Lines 15550 15551 +1
Branches 4000 4001 +1
==========================================
+ Hits 10934 10942 +8
+ Misses 4616 4609 -7
@petebacondarwin sorry I had to tweak some logic here 🙇 , could you please give this PR another quick review?
Also, the broken e2es come from Solid, that's being fixed in https://github.com/cloudflare/workers-sdk/pull/5135 (so I guess we should look into merging 5135 before merging this PR)
~~The e2es are currently failing because of hono, those are getting fixed in https://github.com/cloudflare/workers-sdk/pull/5149~~
All good now 😄