workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

pass legacy-env through versions upload

Open taylorlee opened this issue 1 year ago • 2 comments

What this PR solves / how to test:

Author has addressed the following:

  • Tests

    • [x] Not necessary because: versions upload is experimental, doesn't have test suite yet. This brings it into conformance with standard deploy by not hardcoding is_legacy prop.
  • Changeset (Changeset guidelines)

    • [x] Included

taylorlee avatar Feb 29 '24 20:02 taylorlee

🦋 Changeset detected

Latest commit: 935ab77496034fc8a08269f9349c0561ecee26c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 29 '24 20:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8102340866/npm-package-wrangler-5128

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5128/npm-package-wrangler-5128

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8102340866/npm-package-wrangler-5128 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8102340866/npm-package-create-cloudflare-5128 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8102340866/npm-package-cloudflare-kv-asset-handler-5128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8102340866/npm-package-miniflare-5128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8102340866/npm-package-cloudflare-pages-shared-5128
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8102340866/npm-package-cloudflare-vitest-pool-workers-5128

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 29 '24 20:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.34%. Comparing base (54f6bfc) to head (935ab77). Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5128   +/-   ##
=======================================
  Coverage   70.33%   70.34%           
=======================================
  Files         298      298           
  Lines       15515    15542   +27     
  Branches     3987     3999   +12     
=======================================
+ Hits        10913    10933   +20     
- Misses       4602     4609    +7     
Files Coverage Δ
packages/wrangler/src/versions/index.ts 22.91% <100.00%> (ø)
packages/wrangler/src/versions/upload.ts 11.11% <ø> (ø)

... and 11 files with indirect coverage changes

codecov[bot] avatar Mar 04 '24 16:03 codecov[bot]