workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

chore(wrangler): Configuration keys clean-up

Open CarmenPopoviciu opened this issue 1 year ago • 3 comments

As part of an ongoing "configuration keys in wrangler" audit, this commit cleans up some of the configuration related comments, annotations, aso, in an attempt to keep things consistent and updated across the board.

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • [ ] Included
    • [x] Not necessary because: it's mostly code comments changes
  • Changeset (Changeset guidelines)
    • [ ] Included
    • [ ] Not necessary because:
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [x] Not necessary because: cleaning up docs around configuration will be a separate effort we're tracking internally

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

CarmenPopoviciu avatar Feb 29 '24 14:02 CarmenPopoviciu

⚠️ No Changeset found

Latest commit: 3c26de4d02e6e32a2f64116a5278bcef12c58990

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 29 '24 14:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775208500/npm-package-wrangler-5123

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5123/npm-package-wrangler-5123

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775208500/npm-package-wrangler-5123 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775208500/npm-package-create-cloudflare-5123 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775208500/npm-package-cloudflare-kv-asset-handler-5123
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775208500/npm-package-miniflare-5123
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775208500/npm-package-cloudflare-pages-shared-5123
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775208500/npm-package-cloudflare-vitest-pool-workers-5123

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.2
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 29 '24 14:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.41%. Comparing base (2789f26) to head (49cf774). Report is 51 commits behind head on main.

:exclamation: Current head 49cf774 differs from pull request most recent head 3c26de4. Consider uploading reports for the commit 3c26de4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5123      +/-   ##
==========================================
- Coverage   72.44%   70.41%   -2.04%     
==========================================
  Files         331      298      -33     
  Lines       17298    15519    -1779     
  Branches     4422     3990     -432     
==========================================
- Hits        12532    10927    -1605     
+ Misses       4766     4592     -174     

see 131 files with indirect coverage changes

codecov[bot] avatar Feb 29 '24 14:02 codecov[bot]