workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Add duplex: half property

Open penalosa opened this issue 1 year ago • 3 comments

Fixes #5028

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • [ ] Included
    • [x] Not necessary because: This is pretty much impossible to test with our current setup, since AI requires a logged in E2E account, and we have no E2E tests for exports from Wrangler. This can be a followup
  • Changeset (Changeset guidelines)
    • [x] Included
    • [ ] Not necessary because:
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [x] Not necessary because: bugfix

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

penalosa avatar Feb 28 '24 19:02 penalosa

⚠️ No Changeset found

Latest commit: f108835d2441a7e0375495c78a58c8daf54fee9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 28 '24 19:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8297641262/npm-package-wrangler-5114

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5114/npm-package-wrangler-5114

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8297641262/npm-package-wrangler-5114 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8297641262/npm-package-create-cloudflare-5114 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8297641262/npm-package-cloudflare-kv-asset-handler-5114
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8297641262/npm-package-miniflare-5114
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8297641262/npm-package-cloudflare-pages-shared-5114
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8297641262/npm-package-cloudflare-vitest-pool-workers-5114

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240304.2
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 28 '24 19:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.50%. Comparing base (d4b4c3a) to head (f108835). Report is 86 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5114      +/-   ##
==========================================
+ Coverage   70.33%   71.50%   +1.16%     
==========================================
  Files         298      309      +11     
  Lines       15515    16098     +583     
  Branches     3987     4111     +124     
==========================================
+ Hits        10913    11511     +598     
+ Misses       4602     4587      -15     

see 47 files with indirect coverage changes

codecov[bot] avatar Feb 28 '24 19:02 codecov[bot]

Closing as no longer relevant (see https://github.com/cloudflare/workers-sdk/issues/5028#issuecomment-2022226122)

penalosa avatar Apr 12 '24 01:04 penalosa