workers-sdk
workers-sdk copied to clipboard
Add DeliveryDelay and RetryDelay to create Queue/Consumer commands.
Fixes # MQ-499 internally
What this PR solves / how to test:
Adds support for message delivery delay on create new Queue, and retry delay when create new consumer.
Author has addressed the following:
- Tests
- [x] Included
- [ ] Not necessary because:
- Changeset (Changeset guidelines)
- [x] Included
- [ ] Not necessary because:
- Associated docs
- [ ] Issue(s)/PR(s):
- [ ] Not necessary because:
🦋 Changeset detected
Latest commit: fa222f28b96d2966545bf9348a986a2144e68159
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| wrangler | Minor |
| @cloudflare/vitest-pool-workers | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
A wrangler prerelease is available for testing. You can install this latest build in your project with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8378697493/npm-package-wrangler-5102
You can reference the automatically updated head of this PR with:
npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5102/npm-package-wrangler-5102
Or you can use npx with this latest build directly:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8378697493/npm-package-wrangler-5102 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8378697493/npm-package-create-cloudflare-5102 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8378697493/npm-package-cloudflare-kv-asset-handler-5102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8378697493/npm-package-miniflare-5102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8378697493/npm-package-cloudflare-pages-shared-5102
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8378697493/npm-package-cloudflare-vitest-pool-workers-5102
Note that these links will no longer work once the GitHub Actions artifact expires.
[email protected] includes the following runtime dependencies:
| Package | Constraint | Resolved |
|---|---|---|
miniflare |
workspace:* | 3.20240314.0 |
workerd |
1.20240320.1 | 1.20240320.1 |
workerd --version |
1.20240320.1 | 2024-03-20 |
Please ensure constraints are pinned, and miniflare/workerd minor versions match.
Codecov Report
Attention: Patch coverage is 91.17647% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 72.27%. Comparing base (
e88ad44) to head (fa222f2).
Additional details and impacted files
@@ Coverage Diff @@
## main #5102 +/- ##
==========================================
+ Coverage 72.15% 72.27% +0.11%
==========================================
Files 317 318 +1
Lines 16369 16398 +29
Branches 4168 4174 +6
==========================================
+ Hits 11811 11851 +40
+ Misses 4558 4547 -11
| Files | Coverage Δ | |
|---|---|---|
| ...ler/src/queues/cli/commands/consumer/worker/add.ts | 100.00% <100.00%> (ø) |
|
| ...ackages/wrangler/src/queues/cli/commands/create.ts | 100.00% <100.00%> (ø) |
|
| packages/wrangler/src/queues/client.ts | 96.42% <ø> (ø) |
|
| packages/wrangler/src/queues/constants.ts | 100.00% <100.00%> (ø) |
|
| .../src/queues/cli/commands/consumer/http-pull/add.ts | 94.11% <66.66%> (-5.89%) |
:arrow_down: |
| packages/wrangler/src/queues/utils.ts | 88.23% <77.77%> (-0.66%) |
:arrow_down: |
This looks solid to me, I think you are good to open it up for review by the wrangler team.
What does this mean?
Associated docs
Not necessary because: full range of options not yet documented.
Are you saying that you don't need to add docs for this because there are none at all yet? At the least I think it would be good to create a placeholder issue in the docs repo, to track that this needs to be done at some point (soonish?).
@petebacondarwin
What does this mean?
Associated docs Not necessary because: full range of options not yet documented.Are you saying that you don't need to add docs for this because there are none at all yet? At the least I think it would be good to create a placeholder issue in the docs repo, to track that this needs to be done at some point (soonish?).
There is documentation (https://github.com/cloudflare/cloudflare-docs/blob/production/content/workers/wrangler/commands.md#queues), it's just the [OPTIONS] that are lacking. I'll check if we already have an issue for that.
I've created an issue in the docs repo to track the addition of the OPTIONS descriptions: https://github.com/cloudflare/cloudflare-docs/issues/13370.
I see you have changed the title to [do not merge]. So I will also change this to "draft". Please mark it as "ready to review" when you are ready.
Approved under LDW with CR-850147