workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Deprecate `version` command

Open RamIdeas opened this issue 1 year ago • 3 comments

What this PR solves / how to test:

This PR deprecated the wrangler version command. It does the same thing as wrangler --version which can be used instead. Deprecating because it could cause confusion with the upcoming wrangler versions ... commands.

Author has addressed the following:

  • Tests
    • [x] Included
    • [ ] Not necessary because:
  • Changeset (Changeset guidelines)
    • [x] Included
    • [ ] Not necessary because:
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [x] Not necessary because: this command was never documented.

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

RamIdeas avatar Feb 21 '24 12:02 RamIdeas

🦋 Changeset detected

Latest commit: 762ba81ad6f2cb81ebc27c654cb718e26efda22f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 21 '24 12:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-wrangler-5069

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5069/npm-package-wrangler-5069

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-wrangler-5069 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-create-cloudflare-5069 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-kv-asset-handler-5069
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-miniflare-5069
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-pages-shared-5069
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8285728849/npm-package-cloudflare-vitest-pool-workers-5069

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240304.2
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 21 '24 13:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.50%. Comparing base (0c535e7) to head (762ba81).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5069      +/-   ##
==========================================
+ Coverage   71.46%   71.50%   +0.03%     
==========================================
  Files         309      309              
  Lines       16097    16098       +1     
  Branches     4111     4111              
==========================================
+ Hits        11504    11511       +7     
+ Misses       4593     4587       -6     
Files Coverage Δ
packages/wrangler/src/index.ts 90.53% <100.00%> (+0.02%) :arrow_up:

... and 6 files with indirect coverage changes

codecov[bot] avatar Feb 21 '24 13:02 codecov[bot]