workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Update VSCode to 1.85.2, including updates to TypeScript

Open penalosa opened this issue 1 year ago • 3 comments

What this PR solves / how to test:

This updates the set of VSCode patches for the quick editor to be based of 1.85.2, rather than 1.76.0.

This can be tested by modifying the Quick Edit URL in a local copy of the Workers Playground or the dashboard to point to the prerelease build generated by this PR (https://cdf6467f.quick-edit-cny.pages.dev/). Particular attention should be paid to TypeScript (through JSDoc) support.

Author has addressed the following:

  • Tests
    • [ ] Included
    • [x] Not included because: Must be manually tested
  • Changeset (Changeset guidelines)
    • [ ] Included
    • [x] Not necessary because: Not relevant
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [x] Not necessary because: Not relevant

penalosa avatar Feb 19 '24 11:02 penalosa

⚠️ No Changeset found

Latest commit: 25305d9e72917499f951bb3e32ec2359109b6a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 19 '24 11:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775074013/npm-package-wrangler-5054

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5054/npm-package-wrangler-5054

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775074013/npm-package-wrangler-5054 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775074013/npm-package-create-cloudflare-5054 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775074013/npm-package-cloudflare-kv-asset-handler-5054
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775074013/npm-package-miniflare-5054
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775074013/npm-package-cloudflare-pages-shared-5054
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8775074013/npm-package-cloudflare-vitest-pool-workers-5054

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.2
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 19 '24 11:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.40%. Comparing base (2789f26) to head (b5efb74). Report is 50 commits behind head on main.

:exclamation: Current head b5efb74 differs from pull request most recent head 25305d9. Consider uploading reports for the commit 25305d9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5054      +/-   ##
==========================================
- Coverage   72.44%   70.40%   -2.05%     
==========================================
  Files         331      298      -33     
  Lines       17298    15463    -1835     
  Branches     4422     3966     -456     
==========================================
- Hits        12532    10887    -1645     
+ Misses       4766     4576     -190     

see 134 files with indirect coverage changes

codecov[bot] avatar Feb 19 '24 11:02 codecov[bot]

Without a changeset we will no longer deploy this to production, I believe.

petebacondarwin avatar Mar 12 '24 21:03 petebacondarwin

I have no idea how to go about reviewing all those patch changes! But otherwise this seems like a good change. How do we test this stuff?

The best way to test this is to run a local copy of the workers playground, and modify the editor URL to point to the prerelease from this branch, and then play around and try and break it

penalosa avatar Mar 14 '24 14:03 penalosa

@petebacondarwin will you be able to test this per @penalosa 's instructions?

lrapoport-cf avatar Mar 18 '24 15:03 lrapoport-cf

I tried this out locally. It seems to be working although I couldn't identify any of the new VS code features in our usage. For example, interactive inlay hints or new refactorings. But these might just not be available in our current setup.

petebacondarwin avatar Mar 18 '24 18:03 petebacondarwin

Needs a rebase then it is good to land.

petebacondarwin avatar Mar 18 '24 18:03 petebacondarwin