workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Update R2 Error Handling for Invalid Characters

Open db-cloudflare opened this issue 1 year ago • 3 comments

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test: Adds client side error handling for creating an R2 bucket with invalid characters Author has addressed the following:

  • Tests
    • [x] Included
    • [ ] Not necessary because:
  • Changeset (Changeset guidelines)
    • [x] Included
    • [ ] Not necessary because:
  • Associated docs
    • [x] Issue(s)/PR(s):
    • [ ] Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

db-cloudflare avatar Feb 16 '24 13:02 db-cloudflare

🦋 Changeset detected

Latest commit: 398125302bd2103730c8171f35d982c529a49d36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 16 '24 13:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9889399659/npm-package-wrangler-5032

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5032/npm-package-wrangler-5032

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9889399659/npm-package-wrangler-5032 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9889399659/npm-package-create-cloudflare-5032 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9889399659/npm-package-cloudflare-kv-asset-handler-5032
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9889399659/npm-package-miniflare-5032
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9889399659/npm-package-cloudflare-pages-shared-5032
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9889399659/npm-package-cloudflare-vitest-pool-workers-5032

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240701.0
workerd 1.20240701.0 1.20240701.0
workerd --version 1.20240701.0 2024-07-01

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 19 '24 12:02 github-actions[bot]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.36%. Comparing base (65da40a) to head (f8147db). Report is 486 commits behind head on main.

:exclamation: Current head f8147db differs from pull request most recent head 08c4258. Consider uploading reports for the commit 08c4258 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5032      +/-   ##
==========================================
- Coverage   70.64%   70.36%   -0.29%     
==========================================
  Files         292      298       +6     
  Lines       15178    15518     +340     
  Branches     3860     3985     +125     
==========================================
+ Hits        10723    10919     +196     
- Misses       4455     4599     +144     
Files Coverage Δ
packages/wrangler/src/r2/index.ts 86.62% <100.00%> (-0.28%) :arrow_down:
packages/wrangler/src/r2/helpers.ts 88.50% <80.00%> (-0.39%) :arrow_down:

... and 64 files with indirect coverage changes

codecov[bot] avatar Feb 29 '24 17:02 codecov[bot]

I ran the E2E tests locally.

petebacondarwin avatar Jul 11 '24 10:07 petebacondarwin