workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Fix CSP:script-src in 0015-Basic-support-for-Safari.patch (#4737)

Open neilsh opened this issue 1 year ago • 2 comments

Potential fix for https://github.com/cloudflare/workers-sdk/issues/4737. Note that I haven't tested this myself, as I don't have an environment set up for wrangler-devtools -- feel free to modify this from draft->ready once tested.

Fixes #4737

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • [ ] Included
    • [ ] Not necessary because:
  • Changeset (Changeset guidelines)
    • [ ] Included
    • [ ] Not necessary because:
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [ ] Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

neilsh avatar Jan 11 '24 05:01 neilsh

🦋 Changeset detected

Latest commit: c2d345843ac029b5da238e2b0c74a62debefc47f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/wrangler-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 11 '24 05:01 changeset-bot[bot]

Also don't have the ability to test this locally. Should we be able to from the Pages preview?

Yes we should, but for some reason that's not currently working. I'm investigating

penalosa avatar Feb 22 '24 16:02 penalosa

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-wrangler-4738

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4738/npm-package-wrangler-4738

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-wrangler-4738 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-create-cloudflare-4738 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-kv-asset-handler-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-miniflare-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-pages-shared-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-vitest-pool-workers-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-workers-editor-shared-4738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10507142557/npm-package-cloudflare-workers-shared-4738

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Jul 08 '24 14:07 github-actions[bot]

Manually tested from a build in https://github.com/cloudflare/workers-sdk/pull/6556

penalosa avatar Aug 22 '24 11:08 penalosa

Congratulations @neilsh, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm05981x694580cllj4qbvgw3

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

holopin-bot[bot] avatar Aug 22 '24 12:08 holopin-bot[bot]