workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Update esbuild to v0.18.20

Open jspspike opened this issue 2 years ago • 1 comments

Describe the solution

Update esbuild on next major wrangler update. We can update to 19 once this issue gets resolved

jspspike avatar Sep 15 '23 19:09 jspspike

The latest esbuild is 0.20.1. Are we still limited to 0.18+?

admah avatar Feb 23 '24 06:02 admah

Until that issue is resolved, yes. Has anyone in DevProd looked into putting up a PR against esbuild?

GregBrimble avatar Mar 08 '24 16:03 GregBrimble

Has anyone in DevProd looked into putting up a PR against esbuild?

@GregBrimble yep, we did look into this. Looks like a PR to add a flag to disable the behaviour would be doable, but we weren't sure whether it would be accepted. There are other options too like trying to pass glob patterns/import specifiers through onResolve plugin hooks, but that would be more complicated to implement. Our plan was to bump to 0.18.20 now, then try bump further if we have time. 👍

mrbbot avatar Mar 11 '24 11:03 mrbbot

I've written up some thoughts on upgrading to 0.19.0 and beyond here: https://github.com/cloudflare/workers-sdk/issues/5222.

mrbbot avatar Mar 11 '24 14:03 mrbbot