wildebeest icon indicating copy to clipboard operation
wildebeest copied to clipboard

terraform: explicitly disable auto minify of JS

Open elithrar opened this issue 2 years ago • 4 comments

Auto-minify breaks the Mastodon front-end. This explicitly sets the zone config to disable it.

Ref: https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/zone_settings_override

elithrar avatar Jan 09 '23 15:01 elithrar

Shall we apply these overrides using Configuration Rules? So to keep any existing settings untouched.

xmflsct avatar Jan 09 '23 16:01 xmflsct

yes @xmflsct . One of my concern is touching the zone's setting might not be expected by the user.

xtuc avatar Jan 09 '23 16:01 xtuc

We also need to update the documentation for generating the API token, new permissions are needed for changing zone settings.

xtuc avatar Jan 09 '23 19:01 xtuc

using a configuration ruleset is the correct way to achieve this. you don't want to rely on page rules given they have a limited lifespan thanks to ERE and the replacement phases. in saying that though, this may be impacted by an issue in the SDKv2 where it cannot differentiate unset/false values (which we are addressing with a move to the framework provider) for cloudflare_ruleset.

jacobbednarz avatar Jan 24 '23 23:01 jacobbednarz