cf-terraforming icon indicating copy to clipboard operation
cf-terraforming copied to clipboard

Several Broken Import Resources missing zone_id or using account_id

Open wesleykirkland opened this issue 3 years ago • 0 comments

Confirmation

  • [X] My issue isn't already found on the issue tracker.
  • [X] I have replicated my issue using the latest version of the library and it is still present.

cf-terraforming version

0.8.4

Expected outcome

This is very similar to my previous issue of https://github.com/cloudflare/cf-terraforming/issues/494

The following resources do not generate a zone_id parameter. They require one to be valid, I simply used multi line edit to fix this in my case.

  • cloudflare_page_rule
  • cloudflare_firewall_rule
  • cloudflare_filter

The resource cloudflare_custom_pages assumes the the item is referenced at the account level via account_id when in my case it was referenced via zone_id.

The resource cloudflare_account_member doesn't account for pagination. The default page size is 20 and my import has close to 40 members.

https://github.com/cloudflare/cf-terraforming/blob/41df2c407d391b10b142e52561c8a96cd56f22ed/internal/app/cf-terraforming/cmd/import.go#L84

The code is showing that it's paginating when in reality its not.

Actual outcome

See above

Steps to reproduce

Run generation steps for

  • cloudflare_page_rule
  • cloudflare_firewall_rule
  • cloudflare_filter
  • cloudflare_custom_pages
  • cloudflare_account_member - Have +=21 accounts

References

https://github.com/cloudflare/cf-terraforming/issues/494

wesleykirkland avatar Nov 29 '22 20:11 wesleykirkland