cdk-constructs icon indicating copy to clipboard operation
cdk-constructs copied to clipboard

Fixes for cdk-cloudfront-authorization

Open elliotsegler opened this issue 1 year ago • 1 comments

  • Adjusted user-pool-domain lambda to use region directly instead of from the cognito client resolved config (Fix for #211)
  • Updated Authorizations and AuthFlow to add a sane default for httpHeaders (which was causing the edge functions to error and fail (including the example code), and updated test snapshots for the same - fixes #171
  • Updated the cdk-lambda-at-edge-pattern WithConfiguration construct lambda function to wait for the Lambda function status to go Active and then wait for propagation, which was causing distribution deployments (including the example) to fail

Build results:

 Lerna (powered by Nx)   Successfully ran target build for 45 projects (2m)

Test results:

Test Suites: 42 passed, 42 total
Tests:       106 passed, 106 total
Snapshots:   64 passed, 64 total
Time:        5.705 s
Ran all test suites in 27 projects.

*Note: I didn't see any tests for the lambda functions, but I've tested this in my own envionment

elliotsegler avatar May 26 '24 08:05 elliotsegler

I bundled a couple of these fixes together, please let me know if you'd rather I split it into multiple PRs.

elliotsegler avatar Jun 04 '24 07:06 elliotsegler