garm icon indicating copy to clipboard operation
garm copied to clipboard

Pools shouldn't contain the default labels `self-hosted`, `$OS_ARCH` and `$OS_TYPE`

Open bavarianbidi opened this issue 1 year ago • 2 comments

To get action runners without default-labels, the following things has to be done

ToDos

  • [x] garm-provider-common has to make use of the --no-default-labels flag :heavy_check_mark:
  • [x] garm-provider-common must be released :hourglass_flowing_sand:
  • [ ] providers make use of the new garm-provider-common version
    • [x] openstack
    • [x] azure
    • [ ] gcp
    • [ ] oci
    • [ ] aws
    • [ ] lxd
    • [ ] incus
    • [ ] equinix
  • [x] #250 implementation is ongoing here
  • [ ] describe new behavior

bavarianbidi avatar May 21 '24 06:05 bavarianbidi

also, any other external providers that use garm-provider-common will need to update before being used with the next version of GARM. Or any other provider that does not use the common package, but sets up the runner using a registration token.

Nothing terrible will happen if they don't but their runner may pick up a job on a workflow with self-hosted. GARM should react based on webhooks, so it should be fine. What it won't do is schedule a runner if it doesn't have the tag in the DB.

gabriel-samfira avatar May 21 '24 10:05 gabriel-samfira

I accidentally created an issue by clicking a circle next to the text. GitHub AI magic I guess 😅

gabriel-samfira avatar May 22 '24 18:05 gabriel-samfira